Repository navigation
fix(server): repair summary search after snapshots and project adoption - #163
Merged
Merged
Conversation
|
Integrate reviewed main. Recover summary work in the current project and prevent delayed verification from scrubbing a newer publication, including source reversion and legacy rows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The audit found four ways conversation summaries could become unavailable or keep generating work without converging:
Snapshots now rebuild summary FTS from canonical rows and integer-ID mappings, preserving scrub exclusions. Publication can replace an adopted thread's summaries after canonical revalidation while retaining stable IDs. Retry and settings recovery use the current thread project while keeping historical pass provenance. Scrubbing also matches an internal publication revision, so a stale verifier cannot mutate a newer publication. Legacy rows without that revision remain supported.
The revision is private storage metadata. Public summary contracts, IDs, source digests, and model-facing text are unchanged; bounded metadata scans still avoid loading statement bodies.
Verification
Every defect has a regression that failed before its corresponding source fix:
Final owning suites: 56 summary tests and 12 snapshot tests. On the final publication tree,
vp run check:changed 09efb428b74ef6a1d22be25bdba9c62f8a180669 --concurrency 1passed native build, formatting, lint, both full Knip scans, GraphQL generation, and 70 tests across three files, including Agent Context Budget.The cached compiler launcher cannot initialize
seccomp_unotifyin this environment, so that gate invocation exits nonzero. All three affected packages passed their configuredeffect-tsgo tsrs --noEmitchecks directly: server, evals, and scripts. No compiler settings, CI checks, or budget gates were weakened.Independent review covered the publication and retry changes, the revision guard, and the regressions. The GitHub tree was checked equal to the locally validated tree.
GitHub Fork CI, including final Fork Check, Agent Context Budget, and every other applicable check must pass on the exact published head before merge. Generation uses deterministic model fixtures; private/live-model execution is not claimed.
Implemented and verified with GPT-6 Astra Pro / ChatGPT.